[webkit-changes] [WebKit/WebKit] e8377a: Cherry-pick 270230 at main (67e35fd334d5). https://bu...

Ada Chan noreply at github.com
Fri Nov 10 15:34:15 PST 2023


  Branch: refs/heads/webkitglib/2.42
  Home:   https://github.com/WebKit/WebKit
  Commit: e8377a74da4c714b94ff351c2a3ae50b9c8915a8
      https://github.com/WebKit/WebKit/commit/e8377a74da4c714b94ff351c2a3ae50b9c8915a8
  Author: Ada Chan <adachan at apple.com>
  Date:   2023-11-11 (Sat, 11 Nov 2023)

  Changed paths:
    M Source/WebCore/Modules/webxr/WebXRSession.cpp
    M Source/WebCore/Modules/webxr/WebXRSession.h
    M Source/WebCore/Modules/webxr/WebXRSpace.h

  Log Message:
  -----------
  Cherry-pick 270230 at main (67e35fd334d5). https://bugs.webkit.org/show_bug.cgi?id=264200

    WebXRSession should not hold a unique ptr to WebXRViewerSpace which is ref counted
    https://bugs.webkit.org/show_bug.cgi?id=264200
    rdar://115180471

    Reviewed by Chris Dumez.

    WebXRViewerSpace subclasses EventTarget and therefore should be ref-counted.

    * Source/WebCore/Modules/webxr/WebXRSession.cpp:
    (WebCore::WebXRSession::WebXRSession):
    * Source/WebCore/Modules/webxr/WebXRSession.h:
    * Source/WebCore/Modules/webxr/WebXRSpace.h:
    (WebCore::WebXRViewerSpace::create):

    Canonical link: https://commits.webkit.org/270230@main




More information about the webkit-changes mailing list