[webkit-changes] [WebKit/WebKit] bd2dbd: [UnifiedPDF] PDFs in <embed> and <object> do not clip

Tim Horton noreply at github.com
Fri Nov 10 15:56:43 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bd2dbdec504af98f89d23c0800fe0a7e55b9639f
      https://github.com/WebKit/WebKit/commit/bd2dbdec504af98f89d23c0800fe0a7e55b9639f
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2023-11-10 (Fri, 10 Nov 2023)

  Changed paths:
    M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
    M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
    M Source/WebKit/WebProcess/Plugins/PluginView.cpp
    M Source/WebKit/WebProcess/Plugins/PluginView.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  [UnifiedPDF] PDFs in <embed> and <object> do not clip
https://bugs.webkit.org/show_bug.cgi?id=264622
<rdar://problem/118155018>

Reviewed by Simon Fraser.

* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::updateLayerHierarchy):
Add explicit clipping and scrolling layers.

(WebKit::UnifiedPDFPlugin::didChangeSettings):
Propagate layer border and repaint counter settings when changed.

(WebKit::UnifiedPDFPlugin::didChangeScrollOffset):
Scroll the scrolling layer.

* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::didChangeSettings):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didChangeSettings):
* Source/WebKit/WebProcess/Plugins/PluginView.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Propagate preference changes to PDFPlugin.

Canonical link: https://commits.webkit.org/270573@main




More information about the webkit-changes mailing list