[webkit-changes] [WebKit/WebKit] 3a68fc: TrackConfiguration: report the correct FPS even if...

[Jer Noble]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a68fc73d42afb9ba6e114fec272459a56762a86
      https://github.com/WebKit/WebKit/commit/3a68fc73d42afb9ba6e114fec272459a56762a86
  Author: Jer Noble <jer.noble at apple.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    A LayoutTests/media/media-source/content/test-vp9-23.976fps-manifest.json
    A LayoutTests/media/media-source/content/test-vp9-23.976fps.webm
    A LayoutTests/media/media-source/content/test-vp9-24fps-manifest.json
    A LayoutTests/media/media-source/content/test-vp9-24fps.webm
    A LayoutTests/media/media-source/content/test-vp9-29.97fps-manifest.json
    A LayoutTests/media/media-source/content/test-vp9-29.97fps.webm
    A LayoutTests/media/media-source/content/test-vp9-30fps-manifest.json
    A LayoutTests/media/media-source/content/test-vp9-30fps.webm
    A LayoutTests/media/media-source/media-source-webm-configuration-framerate-expected.txt
    A LayoutTests/media/media-source/media-source-webm-configuration-framerate.html
    M LayoutTests/platform/mac/TestExpectations
    M Source/WebCore/Modules/modern-media-controls/media/media-controller.js
    M Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp

  Log Message:
  -----------
  TrackConfiguration: report the correct FPS even if the WebM FrameRate value is missing
https://bugs.webkit.org/show_bug.cgi?id=256595
rdar://109161531

Reviewed by Eric Carlson.

In the absense of an explicit FrameRate element, use the track's DefaultDuration element
(if present) to calculate the framerate value. Once we are reporting the correct framerate,
we introduce a problem in the Media Stats panel; namely that the frame rate reported from
webm does not lead to a cleanly represented fraction. So update media-controller.js to
round to the nearest 3rd decimal place when displaying the framerate value.

* LayoutTests/media/media-source/content/test-vp9-23.976fps-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-23.976fps.webm: Added.
* LayoutTests/media/media-source/content/test-vp9-24fps-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-24fps.webm: Added.
* LayoutTests/media/media-source/content/test-vp9-29.97fps-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-29.97fps.webm: Added.
* LayoutTests/media/media-source/content/test-vp9-30fps-manifest.json: Added.
* LayoutTests/media/media-source/content/test-vp9-30fps.webm: Added.
* LayoutTests/media/media-source/media-source-webm-configuration-framerate-expected.txt: Added.
* LayoutTests/media/media-source/media-source-webm-configuration-framerate.html: Added.
* Source/WebCore/Modules/modern-media-controls/media/media-controller.js:
(MediaController.prototype.setShowingStats):
* Source/WebCore/platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:
(WebCore::VideoTrackPrivateWebM::framerate const):

Canonical link: https://commits.webkit.org/263964@main