[webkit-changes] [WebKit/WebKit] b614d2: git-webkit prints "error: invalid key:" during pre...

Elliott Williams noreply at github.com
Thu May 11 07:50:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b614d2729f547c08146a1ee78ef81c1818c7aec4
      https://github.com/WebKit/WebKit/commit/b614d2729f547c08146a1ee78ef81c1818c7aec4
  Author: Elliott Williams <emw at apple.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    M Tools/Scripts/hooks/prepare-commit-msg

  Log Message:
  -----------
  git-webkit prints "error: invalid key:" during prepare-commit-msg
https://bugs.webkit.org/show_bug.cgi?id=256534
rdar://109107387

Reviewed by Jonathan Bedard.

git-config(1) exits "1" when a key is missing, which is an expected
case for the hook. AFAICT, there's not a good way to silence the error,
so capture stderr when making the call and only print it out if
git-config fails with a *different* exit code.

* Tools/Scripts/hooks/prepare-commit-msg:

Canonical link: https://commits.webkit.org/263965@main




More information about the webkit-changes mailing list