[webkit-changes] [WebKit/WebKit] 6e8903: WebSocket's binaryType setter should not throw

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e89039cfb2d2f7701a6c33cab9c24055d9291f6
      https://github.com/WebKit/WebKit/commit/6e89039cfb2d2f7701a6c33cab9c24055d9291f6
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/http/tests/websocket/tests/hybi/binary-type-expected.txt
    M LayoutTests/http/tests/websocket/tests/hybi/binary-type.html
    M LayoutTests/imported/w3c/web-platform-tests/websockets/binaryType-wrong-value.any.worker_wss-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/websockets/binaryType-wrong-value.any_wss-expected.txt
    M Source/WebCore/Modules/websockets/WebSocket.cpp
    M Source/WebCore/Modules/websockets/WebSocket.h
    M Source/WebCore/Modules/websockets/WebSocket.idl
    M Source/WebCore/xml/XMLHttpRequest.h

  Log Message:
  -----------
  WebSocket's binaryType setter should not throw
https://bugs.webkit.org/show_bug.cgi?id=256580
rdar://109192086

Reviewed by Antti Koivisto.

Align WebSocket.idl with the WebSockets Standard. In particular:

- binaryType is now an enum
- protocol and extensions are no longer nullable (I don't think they ever returned null)

* LayoutTests/TestExpectations:
* LayoutTests/http/tests/websocket/tests/hybi/binary-type-expected.txt:
* LayoutTests/http/tests/websocket/tests/hybi/binary-type.html:
* LayoutTests/imported/w3c/web-platform-tests/websockets/binaryType-wrong-value.any.worker_wss-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/websockets/binaryType-wrong-value.any_wss-expected.txt:
* Source/WebCore/Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::setBinaryType):
(WebCore::WebSocket::didReceiveBinaryData):
(WebCore::WebSocket::binaryType const): Deleted.
* Source/WebCore/Modules/websockets/WebSocket.h:
(WebCore::WebSocket::binaryType const):
* Source/WebCore/Modules/websockets/WebSocket.idl:
* Source/WebCore/xml/XMLHttpRequest.h:
(WebCore::XMLHttpRequest::responseType const): Deleted.
(WebCore::XMLHttpRequest::readyState const): Deleted.

Inline these into their declaration as well, matching WebSocket's binaryType(), per a review nit.

Canonical link: https://commits.webkit.org/263963@main