[webkit-changes] [WebKit/WebKit] 161a1a: [LibWebRTC] Consolidate export files and add testi...

Commit Queue noreply at github.com
Thu May 11 06:58:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 161a1abe6d0775b2fbf001f328aabdeea38cf19c
      https://github.com/WebKit/WebKit/commit/161a1abe6d0775b2fbf001f328aabdeea38cf19c
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-05-11 (Thu, 11 May 2023)

  Changed paths:
    M Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig
    A Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp
    R Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp
    R Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp
    R Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp
    A Source/ThirdParty/libwebrtc/Configurations/libwebrtc.testing.exp
    M Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig
    R Source/ThirdParty/libwebrtc/Configurations/libwebrtc2.exp
    R Source/ThirdParty/libwebrtc/Configurations/libwebrtc4.exp
    M Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

  Log Message:
  -----------
  [LibWebRTC] Consolidate export files and add testing exports
https://bugs.webkit.org/show_bug.cgi?id=256560
<rdar://109122945>

Reviewed by Youenn Fablet.

General clean-up of libwebrtc export files.  Adds the ability to
export symbols only for testing by introducing a build phase
script in Xcode.

* Source/ThirdParty/libwebrtc/Configurations/DebugRelease.xcconfig:
(WK_EXPORT_SYMBOLS_FOR_TESTING): Add.
- Setting this Xcode variable enables the symbols in
  libwebrtc.testing.exp to be exported when building Debug or
  Release configurations.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.exp: Renamed from Source/ThirdParty/libwebrtc/Configurations/libwebrtc.mac.exp.
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOS.exp: Remove.
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.iOSsim.exp: Remove.
- The symbols in all three files were identical, so consolidated
  them into a single export file.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.testing.exp: Add.
- List of symbols to export when testing.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig:
(EXPORTED_SYMBOLS_FILE):
- Update to point to generate export file created by "Generate
  Export Files" build phase script.

* Source/ThirdParty/libwebrtc/Configurations/libwebrtc2.exp: Remove.
* Source/ThirdParty/libwebrtc/Configurations/libwebrtc4.exp: Remove.
- Remove unused export symbol dumps.

* Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:
- Rename libwebrtc.mac.exp to libwebrtc.exp, and remove deleted
  files.
(Generate Export Files): Add.
- Add build phase script to generate libwebrtc export file.

Canonical link: https://commits.webkit.org/263962@main




More information about the webkit-changes mailing list