[webkit-changes] [WebKit/WebKit] 5e5a72: WebContent logging is being redacted

Per Arne Vollan noreply at github.com
Tue May 9 10:48:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5e5a722eefb0db9babd30b47bcdf32bee95284b8
      https://github.com/WebKit/WebKit/commit/5e5a722eefb0db9babd30b47bcdf32bee95284b8
  Author: Per Arne Vollan <pvollan at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp

  Log Message:
  -----------
  WebContent logging is being redacted
https://bugs.webkit.org/show_bug.cgi?id=256523
rdar://109095468

Reviewed by Chris Dumez and Alexey Proskuryakov.

When forwarding WebContent logs to the Networking process, the logs are being redacted in non internal builds.
This patch addresses this by switching to '%{public}s' in the format string for the preprocessed string from
the WebContent process. This should not reveal any redacted information in the string, since it has already
been composed in the WebContent process.

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::logOnBehalfOfWebContent):

Canonical link: https://commits.webkit.org/263871@main




More information about the webkit-changes mailing list