[webkit-changes] [WebKit/WebKit] 77a93a: Make threadGlobalData inlined

Yusuke Suzuki noreply at github.com
Tue May 9 11:10:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77a93a825be95c43038288b174a73d817d5b5f66
      https://github.com/WebKit/WebKit/commit/77a93a825be95c43038288b174a73d817d5b5f66
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M Source/WTF/wtf/Threading.h
    M Source/WebCore/platform/ThreadGlobalData.cpp
    M Source/WebCore/platform/ThreadGlobalData.h

  Log Message:
  -----------
  Make threadGlobalData inlined
https://bugs.webkit.org/show_bug.cgi?id=256425
rdar://108999187

Reviewed by Justin Michaud.

WebCore::threadGlobalData is not inlined, which is silly.
Let's just define it inlined function. And put LIKELY / UNLIKELY appropriately
to make our fastest path super fast.

    mrs     x26, TPIDRRO_EL0
    ldr     x8, [x26, #0x2e0]
    cbz     x8, 0x11e284
    ldr     x21, [x8, #0x68]
    cbnz    x21, 0x11e28c
    bl      WebCore::threadGlobalDataSlow()

* Source/WebCore/platform/ThreadGlobalData.cpp:
(WebCore::threadGlobalDataSlow):
(WebCore::threadGlobalData): Deleted.
* Source/WebCore/platform/ThreadGlobalData.h:
(WebCore::threadGlobalData):

Canonical link: https://commits.webkit.org/263872@main




More information about the webkit-changes mailing list