[webkit-changes] [WebKit/WebKit] 37bb9a: Fix assert crash "SHOULD NEVER BE REACHED" in Styl...

Vitor Roriz noreply at github.com
Tue May 9 10:37:23 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 37bb9afc0b4754f5f5de0be58acc1bb9752dd12f
      https://github.com/WebKit/WebKit/commit/37bb9afc0b4754f5f5de0be58acc1bb9752dd12f
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2023-05-09 (Tue, 09 May 2023)

  Changed paths:
    M LayoutTests/http/tests/css/resources/shared-stylesheet-mutation.js
    M LayoutTests/http/tests/css/resources/shared.css
    M LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt
    M Source/WebCore/css/CSSCounterStyleRule.h

  Log Message:
  -----------
  Fix assert crash "SHOULD NEVER BE REACHED" in StyleRuleCounterStyle
https://bugs.webkit.org/show_bug.cgi?id=256522
rdar://109082260

Reviewed by Antti Koivisto.

We need to add copy for CSSCounterStyleRule since a change
on style will force a copy-on-write operation.

* Source/WebCore/css/CSSCounterStyleRule.h:
Implement copy().

* LayoutTests/http/tests/css/resources/shared.css:
(@counter-style fooCounter):
(@counter-style fooExtends):
- Adding @counter-style rules for exercising the code path tested here.

(@counter-style fooExtends):
* LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
- Testing mutations on new rules.

* LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
- Rebasing the this test for new rules.

Canonical link: https://commits.webkit.org/263870@main




More information about the webkit-changes mailing list