[webkit-changes] [WebKit/WebKit] f3deed: Pass FrameIdentifier to WebFrame constructor

Alex Christensen noreply at github.com
Fri May 5 14:17:22 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f3deed717fdc4b58ceb65458868ea54dad143848
      https://github.com/WebKit/WebKit/commit/f3deed717fdc4b58ceb65458868ea54dad143848
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
    M Source/WebKit/WebProcess/WebPage/WebFrame.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp

  Log Message:
  -----------
  Pass FrameIdentifier to WebFrame constructor
https://bugs.webkit.org/show_bug.cgi?id=256389
rdar://108962529

Reviewed by Chris Dumez.

This not only makes the code cleaner, but it also makes the main frame registered as a message listener
and accessible in the global map before the call to initWithCoreMainFrame in the WebPage constructor,
which I will probably need to use to refactor the DrawingArea setup which happens before the call to
initWithCoreMainFrame in the WebPage constructor.

* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::initWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::createLocalSubframeHostedInAnotherProcess):
(WebKit::WebFrame::createRemoteSubframe):
(WebKit::WebFrame::WebFrame):
(WebKit::WebFrame::~WebFrame):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
(WebKit::WebFrame::create):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::m_appHighlightsVisible):

Canonical link: https://commits.webkit.org/263734@main




More information about the webkit-changes mailing list