[webkit-changes] [WebKit/WebKit] 7fe1a7: [JSC] Remove linkRecordSourceComparator

Yusuke Suzuki noreply at github.com
Fri May 5 14:48:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7fe1a751b5e3dedf65904b79c6cdd3a1fdd7f53b
      https://github.com/WebKit/WebKit/commit/7fe1a751b5e3dedf65904b79c6cdd3a1fdd7f53b
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2023-05-05 (Fri, 05 May 2023)

  Changed paths:
    M Source/JavaScriptCore/assembler/ARM64Assembler.h
    M Source/JavaScriptCore/assembler/ARMv7Assembler.h

  Log Message:
  -----------
  [JSC] Remove linkRecordSourceComparator
https://bugs.webkit.org/show_bug.cgi?id=256387
rdar://108962105

Reviewed by Alexey Shvayka and Justin Michaud.

We observed some samples of this function and it is discouraged that passing a function ptr to std::sort etc.,
since compiler fails to inline it (type information does not identify one function). Using lambda fixes this issue.

* Source/JavaScriptCore/assembler/ARM64Assembler.h:
* Source/JavaScriptCore/assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::jumpsToLink):
(JSC::ARMv7Assembler::linkRecordSourceComparator): Deleted.

Canonical link: https://commits.webkit.org/263735@main




More information about the webkit-changes mailing list