[webkit-changes] [WebKit/WebKit] 1274b2: Fix test crash because of missing copy() method

Matthieu Dubet noreply at github.com
Fri Mar 17 17:50:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1274b2e8578441d52ca523154721d24ccd4f8335
      https://github.com/WebKit/WebKit/commit/1274b2e8578441d52ca523154721d24ccd4f8335
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Source/WebCore/css/CSSStyleRule.cpp
    M Source/WebCore/css/StyleRule.cpp
    M Source/WebCore/css/StyleRule.h

  Log Message:
  -----------
  Fix test crash because of missing copy() method
https://bugs.webkit.org/show_bug.cgi?id=253723
rdar://106561354

Reviewed by Brent Fulgham.

The visitDerived() dispatcher was calling StyleRule::copy()
because there was no implementation for StyleRuleWithNesting::copy().

A follow-up patch could improve the static assertion in copy() to catch that
at compile-time.

* Source/WebCore/css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reattach):
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRuleWithNesting::copy const):
(WebCore::StyleRuleWithNesting::StyleRuleWithNesting):
(WebCore::m_originalSelectorList):
* Source/WebCore/css/StyleRule.h:

Canonical link: https://commits.webkit.org/261815@main




More information about the webkit-changes mailing list