[webkit-changes] [WebKit/WebKit] 83988a: Make sure line layout path gets invalidated when t...

Alan Baradlay noreply at github.com
Fri Mar 17 16:53:54 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 83988a5b50a0c8f73ef68b263635e920bd0f6b39
      https://github.com/WebKit/WebKit/commit/83988a5b50a0c8f73ef68b263635e920bd0f6b39
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    A LayoutTests/fast/inline/non-supported-ifc-content-crash-after-mutation-expected.txt
    A LayoutTests/fast/inline/non-supported-ifc-content-crash-after-mutation.html
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  Make sure line layout path gets invalidated when the mutated content is not supported
https://bugs.webkit.org/show_bug.cgi?id=254083

Reviewed by Antti Koivisto.

This patch ensures that we invalidate the line layout codepath even when the type of mutation is supported (e.g. it's all text content),
but the block container is not IFC compatible anymore (e.g. has columns).
(i.e. "shouldInvalidateLineLayoutPath" should stay true when "canUseFor" is false.)

* LayoutTests/fast/inline/non-supported-ifc-content-crash-after-mutation-expected.txt: Added.
* LayoutTests/fast/inline/non-supported-ifc-content-crash-after-mutation.html: Added.
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::shouldInvalidateLineLayoutPathAfterChangeFor):
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::invalidateLineLayoutAfterTreeMutationIfNeeded):

Canonical link: https://commits.webkit.org/261814@main




More information about the webkit-changes mailing list