[webkit-changes] [WebKit/WebKit] 0767a6: Fix the iOS TestWebKitAPI build when using recent ...

Wenson Hsieh noreply at github.com
Fri Mar 17 18:27:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 0767a6cd49edd9ba08c6b8f4bc545390c8fbe223
      https://github.com/WebKit/WebKit/commit/0767a6cd49edd9ba08c6b8f4bc545390c8fbe223
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-03-17 (Fri, 17 Mar 2023)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp
    R Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd
    M Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd

  Log Message:
  -----------
  Fix the iOS TestWebKitAPI build when using recent versions of libTAPI
https://bugs.webkit.org/show_bug.cgi?id=254085
rdar://106726247

Reviewed by Tim Horton.

On some recent versions of libTAPI, the `.tbd` parser no longer recognizes multiple platforms that
are listed in v2 `.tbd` files; this causes missing symbols when attempting to weak link
`TestWTFAlwaysMissing*` from (intentionally missing) test dylibs, which only have corresponding
library .tbd stubs but no binary. To work around this (and modernize our TBDs while we're at it),
adopt the newer v4 TBD format (which is supported on all iOS 16-aligned SDKs).

Since we support this TBD format in all configurations that build against iOS, we no longer need
separate versions of the TBD either, so we also take the opportunity to consolidate it into a single
(v4) TBD file.

* Tools/TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
* Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS-v2.tbd: Removed.
* Tools/TestWebKitAPI/Tests/WTF/darwin/libTestWTFAlwaysMissing-iOS.tbd:

Canonical link: https://commits.webkit.org/261816@main




More information about the webkit-changes mailing list