[webkit-changes] [WebKit/WebKit] af0daf: [popover] Throw exception when calling dialog.show...

Tim Nguyen noreply at github.com
Tue Mar 7 18:39:28 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: af0daf6f720f13d60c71fd01b2981ac7f9fdd8a3
      https://github.com/WebKit/WebKit/commit/af0daf6f720f13d60c71fd01b2981ac7f9fdd8a3
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations-expected.txt
    M Source/WebCore/html/HTMLDialogElement.cpp
    M Source/WebCore/html/HTMLDialogElement.h

  Log Message:
  -----------
  [popover] Throw exception when calling dialog.show() on an open popover
https://bugs.webkit.org/show_bug.cgi?id=253538
rdar://106383178

Reviewed by Cameron McCormack.

https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-show

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations-expected.txt:
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
* Source/WebCore/html/HTMLDialogElement.h:

Canonical link: https://commits.webkit.org/261351@main




More information about the webkit-changes mailing list