[webkit-changes] [WebKit/WebKit] 3999b0: Avoid call to exitRemovedFullscreenElementIfNeeded...

Chris Dumez noreply at github.com
Tue Mar 7 19:09:59 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3999b09acdfd8367e857afd5a3c7519a9f8b7727
      https://github.com/WebKit/WebKit/commit/3999b09acdfd8367e857afd5a3c7519a9f8b7727
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-03-07 (Tue, 07 Mar 2023)

  Changed paths:
    M Source/WebCore/dom/Element.cpp
    M Source/WebCore/dom/FullscreenManager.cpp
    M Source/WebCore/dom/FullscreenManager.h

  Log Message:
  -----------
  Avoid call to exitRemovedFullscreenElementIfNeeded() in Element::removedFromAncestor()
https://bugs.webkit.org/show_bug.cgi?id=253539

Reviewed by Tim Nguyen and Ryosuke Niwa.

Avoid call to exitRemovedFullscreenElementIfNeeded() in Element::removedFromAncestor()
in the common case where the element is not fullscreen. Element::removedFromAncestor()
is a hot code path.

* Source/WebCore/dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
* Source/WebCore/dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::exitRemovedFullscreenElement):
(WebCore::FullscreenManager::exitRemovedFullscreenElementIfNeeded): Deleted.
* Source/WebCore/dom/FullscreenManager.h:

Canonical link: https://commits.webkit.org/261352@main




More information about the webkit-changes mailing list