[webkit-changes] [WebKit/WebKit] 8bbc29: REGRESSION(260575 at main): [macOS] PiP mode causes v...
Jer Noble
noreply at github.com
Tue Mar 7 18:29:47 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8bbc299e348e8f6f0aa761d504405a13ce4bd4da
https://github.com/WebKit/WebKit/commit/8bbc299e348e8f6f0aa761d504405a13ce4bd4da
Author: Jer Noble <jer.noble at apple.com>
Date: 2023-03-07 (Tue, 07 Mar 2023)
Changed paths:
M Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm
Log Message:
-----------
REGRESSION(260575 at main): [macOS] PiP mode causes video to zoom in
https://bugs.webkit.org/show_bug.cgi?id=253491
rdar://106201886
Reviewed by Eric Carlson.
Move away from sending setVideoLayerFrame() calls directly (which in addition to being a sync
message to the WebContent and GPU process is also slow), adopt WebAVPlayerLayer, which is what
is used for inline video playback, and is used for fullscreen and PiP on iOS.
* Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:
(-[WebVideoFullscreenInterfaceMacObjC invalidateFullscreenState]):
(-[WebVideoFullscreenInterfaceMacObjC setVideoDimensions:]):
(-[WebVideoFullscreenInterfaceMacObjC setUpPIPForVideoView:withFrame:inWindow:]):
(-[WebVideoFullscreenInterfaceMacObjC boundsDidChangeForVideoViewContainer:]):
Canonical link: https://commits.webkit.org/261350@main
More information about the webkit-changes
mailing list