[webkit-changes] [WebKit/WebKit] 82aa44: REGRESSION: css3/color-filters/color-filter-caret-...

Richard Robinson noreply at github.com
Mon Jun 26 12:47:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 82aa44bd18f4bdea6e6b6f992fb14afc933f0c64
      https://github.com/WebKit/WebKit/commit/82aa44bd18f4bdea6e6b6f992fb14afc933f0c64
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M LayoutTests/css3/color-filters/color-filter-caret-color-expected.html
    M LayoutTests/css3/color-filters/color-filter-caret-color.html
    M Source/WebCore/editing/FrameSelection.cpp

  Log Message:
  -----------
  REGRESSION: css3/color-filters/color-filter-caret-color.html is a consistent image failure
https://bugs.webkit.org/show_bug.cgi?id=258488
rdar://111077813

Reviewed by Simon Fraser.

Apply the color filter when computing the caret color.

Also fixes the test to account for the new shape of the redesigned text cursor.

* LayoutTests/css3/color-filters/color-filter-caret-color-expected.html:
* LayoutTests/css3/color-filters/color-filter-caret-color.html:
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::CaretBase::computeCaretColor):

Canonical link: https://commits.webkit.org/265524@main




More information about the webkit-changes mailing list