[webkit-changes] [WebKit/WebKit] 3a0aed: [buildbot] Clean-up unit tests

Jonathan Bedard noreply at github.com
Mon Jun 26 11:09:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3a0aed5a7de59af70e3596b4db8c03156ce479b6
      https://github.com/WebKit/WebKit/commit/3a0aed5a7de59af70e3596b4db8c03156ce479b6
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-06-26 (Mon, 26 Jun 2023)

  Changed paths:
    M Tools/CISupport/build-webkit-org/loadConfig_unittest.py
    M Tools/CISupport/ews-build/loadConfig.py
    M Tools/CISupport/ews-build/steps.py

  Log Message:
  -----------
  [buildbot] Clean-up unit tests
https://bugs.webkit.org/show_bug.cgi?id=258523
rdar://111337319

Reviewed by Aakash Jain.

* Tools/CISupport/build-webkit-org/loadConfig_unittest.py:
(ConfigDotJSONTest.get_config): Close file after using it.
* Tools/CISupport/ews-build/loadConfig.py:
(loadBuilderConfig): Encode regex string as a regex.
* Tools/CISupport/ews-build/steps.py:
(GitHub.email_for_owners): Treat entire string as error, not each character.
(ConfigureBuild.add_pr_details): Error is logged in step, don't log on master.
(ValidateChange.send_email_for_github_failure): Escape escape sequences.
(ValidateCommitterAndReviewer.run): Error is logged in step, don't log on master.
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure): Ditto.
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures): Ditto.
(ValidateCommitMessage.run): Ditto.
(Canonicalize.run): Ditto.

Canonical link: https://commits.webkit.org/265523@main




More information about the webkit-changes mailing list