[webkit-changes] [WebKit/WebKit] 0ed9d9: dominant-baseline property should be inherited
Ahmad Saleem
noreply at github.com
Mon Jun 26 13:10:17 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0ed9d940afc3aac44f07b5f0b68626972aeeb6c1
https://github.com/WebKit/WebKit/commit/0ed9d940afc3aac44f07b5f0b68626972aeeb6c1
Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
Date: 2023-06-26 (Mon, 26 Jun 2023)
Changed paths:
M LayoutTests/platform/glib/svg/custom/alignment-baseline-modes-expected.txt
M LayoutTests/platform/gtk/svg/custom/alignment-baseline-modes-expected.png
M LayoutTests/platform/ios/svg/custom/alignment-baseline-modes-expected.txt
M LayoutTests/platform/mac/svg/custom/alignment-baseline-modes-expected.png
M LayoutTests/platform/mac/svg/custom/alignment-baseline-modes-expected.txt
A LayoutTests/svg/custom/dominant-baseline-inherit-expected.svg
A LayoutTests/svg/custom/dominant-baseline-inherit.svg
M Source/WebCore/css/CSSProperties.json
M Source/WebCore/rendering/style/SVGRenderStyle.cpp
M Source/WebCore/rendering/style/SVGRenderStyle.h
Log Message:
-----------
dominant-baseline property should be inherited
https://bugs.webkit.org/show_bug.cgi?id=139258
Reviewed by Tim Nguyen.
This patch aligns WebKit with Blink / Chromium, Gecko / Firefox
and web spec [1] by making this property inherited.
[1] https://drafts.csswg.org/css-inline/#dominant-baseline
Merge: https://src.chromium.org/viewvc/blink?view=revision&revision=199970
* Source/WebCore/css/CSSProperties.json: Add 'inherited:true'
* Source/WebCore/rendering/style/SVGRenderStyle.cpp:
(SVGRenderStyle::changeRequiresLayout): Change from non-inherited to inherited
* Source/WebCore/rendering/style/SVGRenderStyle.h: functions changes to make 'inherited'
(SVGRenderStyle::setBitDefaults): Ditto
(SVGRenderStyle::InheritedFlags::opeartor==): Update for 'dominantBaseline' (Support / Help from Antoine Quint)
* LayoutTests/svg/custom/dominant-baseline-inherit.svg: Add Test Case
* LayoutTests/svg/custom/dominant-baseline-inherit-expected.svg: Add Test Case Expectation
* LayoutTests/platform/mac/svg/custom/alignment-baseline-modes-expected.txt: Rebaselined
* LayoutTests/platform/mac/svg/custom/alignment-baseline-modes-expected.png: Rebaselined
* LayoutTests/platform/ios/svg/custom/alignment-baseline-modes-expected.txt: Rebaselined
* LayoutTests/platform/gtk/svg/custom/alignment-baseline-modes-expected.png: Rebaselined
* LayoutTests/platform/glib/svg/custom/alignment-baseline-modes-expected.txt: Rebaselined
Canonical link: https://commits.webkit.org/265525@main
More information about the webkit-changes
mailing list