[webkit-changes] [WebKit/WebKit] a62f8b: [MQ] Negative resolutions in media queries should ...

Tim Nguyen noreply at github.com
Sat Jun 17 19:34:07 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a62f8b084d0a2c47115ea6f16d836acd46369bdd
      https://github.com/WebKit/WebKit/commit/a62f8b084d0a2c47115ea6f16d836acd46369bdd
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-06-17 (Sat, 17 Jun 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-negative-range-001.html
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-negative-range-002.html
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html
    M Source/WebCore/css/query/GenericMediaQueryParser.cpp

  Log Message:
  -----------
  [MQ] Negative resolutions in media queries should not be known
https://bugs.webkit.org/show_bug.cgi?id=258250
rdar://110948170

Reviewed by Darin Adler.

As per https://drafts.csswg.org/css-values-4/#resolution-value negative
resolutions are always invalid, even in media queries.

Sync relevant WPT from commit: https://github.com/web-platform-tests/wpt/commit/79cb3ca220e106346a6e64c09019e48e291a6ab6

* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-negative-range-001.html:
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/mq-negative-range-002.html:
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html:
* Source/WebCore/css/query/GenericMediaQueryParser.cpp:
(WebCore::MQ::GenericMediaQueryParserBase::validateFeatureAgainstSchema):

Canonical link: https://commits.webkit.org/265279@main




More information about the webkit-changes mailing list