[webkit-changes] [WebKit/WebKit] 34f838: REGRESSION(264714 at main) 5% regression in Speedomet...

Myles C. Maxfield noreply at github.com
Sat Jun 17 20:25:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 34f838120c4799e51c5dccd4504e6945c5db67e1
      https://github.com/WebKit/WebKit/commit/34f838120c4799e51c5dccd4504e6945c5db67e1
  Author: Myles C. Maxfield <mmaxfield at apple.com>
  Date:   2023-06-17 (Sat, 17 Jun 2023)

  Changed paths:
    M Source/WTF/wtf/text/cf/TextBreakIteratorCFCharacterCluster.h
    M Source/WTF/wtf/text/cf/TextBreakIteratorCFStringTokenizer.h

  Log Message:
  -----------
  REGRESSION(264714 at main) 5% regression in Speedometer 3's Editor-TipTap suite
https://bugs.webkit.org/show_bug.cgi?id=258259
rdar://110926113

Reviewed by Ryosuke Niwa.

There's no need to use the fancy NSString subclass if there is no prior context.
The whole reason the NSString subclass exists is to deal with the prior context.
If we can use CFString directly, that's faster.

* Source/WTF/wtf/text/cf/TextBreakIteratorCFCharacterCluster.h:
(WTF::TextBreakIteratorCFCharacterCluster::setText):
* Source/WTF/wtf/text/cf/TextBreakIteratorCFStringTokenizer.h:
(WTF::TextBreakIteratorCFStringTokenizer::TextBreakIteratorCFStringTokenizer):
(WTF::TextBreakIteratorCFStringTokenizer::setText):
(WTF::TextBreakIteratorCFStringTokenizer::createString):

Canonical link: https://commits.webkit.org/265280@main




More information about the webkit-changes mailing list