[webkit-changes] [WebKit/WebKit] d447cf: [MQ5] Implement `scripting` media feature

Tim Nguyen noreply at github.com
Sat Jun 17 16:13:48 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d447cfd08147b9b7d33a70d7c0c39c0205b70db7
      https://github.com/WebKit/WebKit/commit/d447cfd08147b9b7d33a70d7c0c39c0205b70db7
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-06-17 (Sat, 17 Jun 2023)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-noscript-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-noscript-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-noscript.html
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-script-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-script-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-script.html
    A LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting.html
    M Source/WebCore/css/CSSValueKeywords.in
    M Source/WebCore/css/html.css
    M Source/WebCore/css/query/MediaQueryFeatures.cpp
    M Source/WebCore/css/query/MediaQueryFeatures.h
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [MQ5] Implement `scripting` media feature
https://bugs.webkit.org/show_bug.cgi?id=258218
rdar://110949545

Reviewed by Darin Adler.

https://drafts.csswg.org/mediaqueries-5/#scripting

initial-only matches for printing, none matches when script is disabled, enabled matches the remainder of the time.

Also implement noscript using CSS.

* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-noscript-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-noscript-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-noscript.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-script-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-script-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting-print-script.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/mediaqueries/scripting.html: Added.
Import related WPTs.

* Source/WebCore/css/CSSValueKeywords.in:
* Source/WebCore/css/html.css:
(@media (scripting) noscript):
Implement noscript using CSS, this matches Firefox.

!important so author stylesheets can't override the display value (like before and like other browsers).

* Source/WebCore/css/query/MediaQueryFeatures.cpp:
(WebCore::MQ::Features::scripting):
* Source/WebCore/css/query/MediaQueryFeatures.h:
Add scripting media query feature.

* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::rendererIsEverNeeded):
Implement noscript using CSS, this matches Firefox.

Canonical link: https://commits.webkit.org/265278@main




More information about the webkit-changes mailing list