[webkit-changes] [WebKit/WebKit] dd88e1: Move long-shipping features to the new 'shipping' ...

Brent Fulgham noreply at github.com
Tue Jan 10 16:49:25 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd88e1d7de7148ea7a4ec21bab32bdc265c0cb5a
      https://github.com/WebKit/WebKit/commit/dd88e1d7de7148ea7a4ec21bab32bdc265c0cb5a
  Author: Brent Fulgham <bfulgham at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WTF/Scripts/GeneratePreferences.rb
    M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
    M Source/WebKit/UIProcess/API/APIFeatureStatus.h
    M Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm
    M Source/WebKitLegacy/mac/WebView/WebFeature.h

  Log Message:
  -----------
  Move long-shipping features to the new 'shipping' status
https://bugs.webkit.org/show_bug.cgi?id=250395
<rdar://problem/104081353>

Reviewed by Patrick Angle and Elliott Williams.

Following Bug 247926, we expose 'stable' features to the Safari 'Develop' menu to
support A/B testing by developers so they can isolate the cause of page regression
to specific features.

This has created an overly-cumbersome UI, and surfaced features that cannot be
disabled on the modern web (and which have been shipping for many years).

This patch updates our Feature flag definitions to use 'shipping' for long-shipping
features. These will no longer be displayed in the UI, and the feature toggles will
likely be removed in a future update as they are no longer conditional, but are
foundational to the modern web.

This also corrects MediaSourceEnabled and SafeBrowsing to be 'embedder'.

* Source/WTF/Scripts/GeneratePreferences.rb: Add 'shipping' as a recognized status.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebKit/UIProcess/API/APIFeatureStatus.h
* Source/WebKit/UIProcess/API/Cocoa/_WKFeature.mm
* Source/WebKitLegacy/mac/WebView/WebFeature.h

Canonical link: https://commits.webkit.org/258753@main




More information about the webkit-changes mailing list