[webkit-changes] [WebKit/WebKit] 1a0105: [Forms] Use button instead of push-button appearan...

Tue Jan 10 16:59:54 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1a0105921defca0770820813cdec1e805036c441
      https://github.com/WebKit/WebKit/commit/1a0105921defca0770820813cdec1e805036c441
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M LayoutTests/fast/css/button-height-expected.txt
    M LayoutTests/fast/css/button-height.html
    M LayoutTests/platform/ios/css2.1/20110323/replaced-elements-001-expected.txt
    M LayoutTests/platform/ios/css3/flexbox/flexitem-expected.txt
    M LayoutTests/platform/ios/fast/forms/button-style-color-expected.txt
    M LayoutTests/platform/mac-bigsur/fast/css/continuationCrash-expected.txt
    M LayoutTests/platform/mac-bigsur/fast/forms/button-sizes-expected.txt
    M LayoutTests/platform/mac-bigsur/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/mac-bigsur/tables/mozilla/bugs/bug2479-3-expected.txt
    M LayoutTests/platform/mac-bigsur/tables/mozilla/bugs/bug26178-expected.txt
    M LayoutTests/platform/mac-monterey/fast/forms/button-sizes-expected.txt
    M LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/foreign-object-skew-expected.txt
    M LayoutTests/platform/mac-ventura/fast/forms/button-sizes-expected.txt
    A LayoutTests/platform/mac-ventura/fast/forms/input-button-sizes-expected.txt
    M LayoutTests/platform/mac/css3/flexbox/button-expected.txt
    M LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt
    M LayoutTests/platform/mac/editing/selection/3690703-expected.txt
    M LayoutTests/platform/mac/editing/selection/3690719-expected.txt
    M LayoutTests/platform/mac/editing/selection/4397952-expected.txt
    M LayoutTests/platform/mac/editing/selection/5240265-expected.txt
    M LayoutTests/platform/mac/editing/selection/selection-button-text-expected.txt
    M LayoutTests/platform/mac/fast/block/float/float-avoidance-expected.txt
    M LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt
    M LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt
    M LayoutTests/platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt
    M LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt
    M LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt
    M LayoutTests/platform/mac/fast/forms/001-expected.txt
    M LayoutTests/platform/mac/fast/forms/basic-buttons-expected.txt
    M LayoutTests/platform/mac/fast/forms/blankbuttons-expected.txt
    M LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt
    M LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt
    M LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt
    M LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt
    M LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt
    M LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt
    M LayoutTests/platform/mac/fast/forms/file/file-input-direction-expected.txt
    M LayoutTests/platform/mac/fast/forms/file/file-input-disabled-expected.txt
    M LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt
    M LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt
    M LayoutTests/platform/mac/fast/forms/formmove3-expected.txt
    M LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt
    M LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt
    M LayoutTests/platform/mac/fast/forms/input-value-expected.txt
    M LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.txt
    M LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt
    M LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt
    M LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt
    M LayoutTests/platform/mac/fast/overflow/scrollRevealButton-expected.txt
    M LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt
    M LayoutTests/platform/mac/fast/replaced/width100percent-button-expected.txt
    M LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt
    M LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt
    M LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt
    M LayoutTests/platform/mac/svg/custom/foreign-object-skew-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug1318-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug39209-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug4429-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug52506-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug60749-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt
    M LayoutTests/platform/mac/tables/mozilla/other/move_row-expected.txt
    M LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt
    M LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt
    M LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt
    M Source/WebCore/rendering/RenderTheme.cpp

  Log Message:
  -----------
  [Forms] Use button instead of push-button appearance for input[type=submit|reset|button]
https://bugs.webkit.org/show_bug.cgi?id=238803
rdar://91624840

Reviewed by Aditya Keerthi.

- Fixes bug reported by GOV.UK about font-size not applying on input[type=file]: https://bugs.webkit.org/show_bug.cgi?id=224746
- Fixes input[type=button|reset|submit] not supporting multi-line values: https://bugs.webkit.org/show_bug.cgi?id=190521
- Fixes input[type=button|reset|submit] not honoring font-size/padding/height/etc. properly like other browsers

* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::autoAppearanceForElement const):

Use StyleAppearance::Button instead of StyleAppearance::PushButton

* LayoutTests/fast/css/button-height-expected.txt:
* LayoutTests/fast/css/button-height.html:

Adjust test now that input[type=button] honors height on macOS.

* LayoutTests/platform/ios/css2.1/20110323/replaced-elements-001-expected.txt:
* LayoutTests/platform/ios/css3/flexbox/flexitem-expected.txt:
* LayoutTests/platform/ios/fast/forms/button-style-color-expected.txt:
* LayoutTests/platform/mac-bigsur/fast/css/continuationCrash-expected.txt:
* LayoutTests/platform/mac-bigsur/fast/forms/button-sizes-expected.txt:
* LayoutTests/platform/mac-bigsur/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/mac-bigsur/tables/mozilla/bugs/bug2479-3-expected.txt:
* LayoutTests/platform/mac-bigsur/tables/mozilla/bugs/bug26178-expected.txt:
* LayoutTests/platform/mac-monterey/fast/forms/button-sizes-expected.txt:
* LayoutTests/platform/mac-ventura/fast/forms/button-sizes-expected.txt:
* LayoutTests/platform/mac-ventura/fast/forms/input-button-sizes-expected.txt: Added.
* LayoutTests/platform/mac-ventura-wk2-lbse-text/svg/custom/foreign-object-skew-expected.txt:
* LayoutTests/platform/mac/css3/flexbox/button-expected.txt:
* LayoutTests/platform/mac/editing/selection/3690703-2-expected.txt:
* LayoutTests/platform/mac/editing/selection/3690703-expected.txt:
* LayoutTests/platform/mac/editing/selection/3690719-expected.txt:
* LayoutTests/platform/mac/editing/selection/4397952-expected.txt:
* LayoutTests/platform/mac/editing/selection/5240265-expected.txt:
* LayoutTests/platform/mac/editing/selection/selection-button-text-expected.txt:
* LayoutTests/platform/mac/fast/block/float/float-avoidance-expected.txt:
* LayoutTests/platform/mac/fast/css/continuationCrash-expected.txt:
* LayoutTests/platform/mac/fast/css/input-search-padding-expected.txt:
* LayoutTests/platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
* LayoutTests/platform/mac/fast/css/rtl-ordering-expected.txt:
* LayoutTests/platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* LayoutTests/platform/mac/fast/forms/001-expected.txt:
* LayoutTests/platform/mac/fast/forms/basic-buttons-expected.txt:
* LayoutTests/platform/mac/fast/forms/blankbuttons-expected.txt:
* LayoutTests/platform/mac/fast/forms/box-shadow-override-expected.txt:
* LayoutTests/platform/mac/fast/forms/button-positioned-expected.txt:
* LayoutTests/platform/mac/fast/forms/button-style-color-expected.txt:
* LayoutTests/platform/mac/fast/forms/button-table-styles-expected.txt:
* LayoutTests/platform/mac/fast/forms/button-text-transform-expected.txt:
* LayoutTests/platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* LayoutTests/platform/mac/fast/forms/file/file-input-direction-expected.txt:
* LayoutTests/platform/mac/fast/forms/file/file-input-disabled-expected.txt:
* LayoutTests/platform/mac/fast/forms/file/input-file-re-render-expected.txt:
* LayoutTests/platform/mac/fast/forms/form-element-geometry-expected.txt:
* LayoutTests/platform/mac/fast/forms/formmove3-expected.txt:
* LayoutTests/platform/mac/fast/forms/input-appearance-height-expected.txt:
* LayoutTests/platform/mac/fast/forms/input-button-sizes-expected.txt:
* LayoutTests/platform/mac/fast/forms/input-value-expected.txt:
* LayoutTests/platform/mac/fast/forms/targeted-frame-submission-expected.txt:
* LayoutTests/platform/mac/fast/html/details-replace-summary-child-expected.txt:
* LayoutTests/platform/mac/fast/html/details-replace-text-expected.txt:
* LayoutTests/platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
* LayoutTests/platform/mac/fast/overflow/scrollRevealButton-expected.txt:
* LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt:
* LayoutTests/platform/mac/fast/replaced/width100percent-button-expected.txt:
* LayoutTests/platform/mac/fast/text/international/hindi-spacing-expected.txt:
* LayoutTests/platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* LayoutTests/platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* LayoutTests/platform/mac/svg/custom/foreign-object-skew-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/bugs/bug92647-2-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/dom/tableDom-expected.txt:
* LayoutTests/platform/mac/tables/mozilla/other/move_row-expected.txt:
* LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
* LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:

Rebaseline a bunch of tests.

Canonical link: https://commits.webkit.org/258754@main