[webkit-changes] [WebKit/WebKit] f5f611: gamepad.vibrationActuator.playEffect() should thro...

Chris Dumez noreply at github.com
Tue Jan 10 16:43:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f5f611375e53ede72b6ab8154ffc6e1c2b74ca53
      https://github.com/WebKit/WebKit/commit/f5f611375e53ede72b6ab8154ffc6e1c2b74ca53
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    A LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation-expected.txt
    A LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation.html
    M Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp
    M Source/WebCore/testing/MockGamepad.cpp

  Log Message:
  -----------
  gamepad.vibrationActuator.playEffect() should throw for invalid effect parameters
https://bugs.webkit.org/show_bug.cgi?id=250409

Reviewed by Brent Fulgham.

gamepad.vibrationActuator.playEffect() should throw for invalid effect parameters:
- https://w3c.github.io/gamepad/extensions.html#dom-gamepadhapticactuator-playeffect (Step 1)

* LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation-expected.txt: Added.
* LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation.html: Added.
* Source/WebCore/Modules/gamepad/GamepadHapticActuator.cpp:
(WebCore::areEffectParametersValid):
(WebCore::GamepadHapticActuator::playEffect):
* Source/WebCore/testing/MockGamepad.cpp:
(WebCore::MockGamepad::MockGamepad):

Canonical link: https://commits.webkit.org/258752@main




More information about the webkit-changes mailing list