[webkit-changes] [WebKit/WebKit] 6782d3: font-face src list fails early if component fails

[Vitor Roriz]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6782d34ec7c624ea2eb55b5a927cd86df00bcf2c
      https://github.com/WebKit/WebKit/commit/6782d34ec7c624ea2eb55b5a927cd86df00bcf2c
  Author: Vitor Roriz <vitor.roriz at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M LayoutTests/fast/css/font-face-src-parsing-expected.txt
    M LayoutTests/fast/css/font-face-src-parsing.html
    R LayoutTests/fast/css/font-face-unquoted-local-expected.html
    A LayoutTests/fast/css/font-face-unquoted-local-expected.txt
    M LayoutTests/fast/css/font-face-unquoted-local.html
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-format-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-list-expected.txt
    M Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp

  Log Message:
  -----------
  font-face src list fails early if component fails
https://bugs.webkit.org/show_bug.cgi?id=250332
rdar://104039050

Reviewed by Tim Nguyen.

If one component of the list fails we should not immediately fail the parsing
of font src, since one valid component will validate the descriptor.
Therefore, we should just fail the src descriptor parsing if all components
have failed.

"A component with a parse error does not invalidate the entire descriptor if there's some other valid component present."
Reference: https://github.com/web-platform-tests/wpt/blob/e9470cde64/css/css-fonts/parsing/font-face-src-list.html

* LayoutTests/fast/css/font-face-src-parsing-expected.txt:
* LayoutTests/fast/css/font-face-src-parsing.html:

* LayoutTests/fast/css/font-face-unquoted-local-expected.html: Removed.
* LayoutTests/fast/css/font-face-unquoted-local-expected.txt: Added.
* LayoutTests/fast/css/font-face-unquoted-local.html:
This test was making use of faulty behavior of src list failing early to build the test.

* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-format-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-face-src-list-expected.txt:
* Source/WebCore/css/parser/CSSPropertyParserWorkerSafe.cpp:
(WebCore::CSSPropertyParserHelpersWorkerSafe::consumeFontFaceSrc):

Canonical link: https://commits.webkit.org/258749@main