[webkit-changes] [WebKit/WebKit] 696c77: Potential crash under WebPageProxy::continueNaviga...

Chris Dumez noreply at github.com
Tue Jan 10 15:49:24 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 696c77d0b3f0be05299f08c19f338645a2e8fc6d
      https://github.com/WebKit/WebKit/commit/696c77d0b3f0be05299f08c19f338645a2e8fc6d
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebPageProxy.cpp

  Log Message:
  -----------
  Potential crash under WebPageProxy::continueNavigationInNewProcess()
https://bugs.webkit.org/show_bug.cgi?id=250404
rdar://103382619

Reviewed by Alex Christensen.

Make sure the navigation and m_mainframe are still valid after receiving
the async response to the NetworkProcess::AddAllowedFirstPartyForCookies
IPC. We would previously crash on a null dereference of m_mainFrame in
some cases.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::triggerBrowsingContextGroupSwitchForNavigation):

Canonical link: https://commits.webkit.org/258750@main




More information about the webkit-changes mailing list