[webkit-changes] [WebKit/WebKit] 639329: Unable to reset messages.py unit test results

EWS noreply at github.com
Tue Jan 10 15:40:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 639329ca6b9a6fd8d1886b34f92889d4ce95f874
      https://github.com/WebKit/WebKit/commit/639329ca6b9a6fd8d1886b34f92889d4ce95f874
  Author: David Kilzer <ddkilzer at apple.com>
  Date:   2023-01-10 (Tue, 10 Jan 2023)

  Changed paths:
    M Source/WebKit/Scripts/webkit/messages_unittest.py

  Log Message:
  -----------
  Unable to reset messages.py unit test results
https://bugs.webkit.org/show_bug.cgi?id=250398
<rdar://104085791>

Reviewed by Jonathan Bedard.

Remove the hack that relied on the existence of an internal
unittest.TestProgram.USAGE package variable, and instead just
print out our custom help message first.  (The reason the
internal variable was used was to make the custom help text to
look like it was integrated nicely with the default help text.)

We can't print our custom help message last since the package
exits early when a help switch is passed.

* Source/WebKit/Scripts/webkit/messages_unittest.py:
- Import print_function from __future__ to make the script work
  with python2.7.  Unit tests are still run with both versions.
(add_reset_results_to_unittest_help): Delete.
(parse_sys_argv):
- Print our custom help text if a help switch is used.

Canonical link: https://commits.webkit.org/258748@main




More information about the webkit-changes mailing list