[webkit-changes] [WebKit/WebKit] 7b649b: Use StringParsingBuffer in HTMLFastPathParser

Chris Dumez noreply at github.com
Thu Feb 16 20:31:32 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b649bcd89479eba4c15e3a2cd66fe6edc9fa029
      https://github.com/WebKit/WebKit/commit/7b649bcd89479eba4c15e3a2cd66fe6edc9fa029
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WTF/wtf/text/StringParsingBuffer.h
    M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp

  Log Message:
  -----------
  Use StringParsingBuffer in HTMLFastPathParser
https://bugs.webkit.org/show_bug.cgi?id=252407

Reviewed by Darin Adler.

Use StringParsingBuffer in HTMLFastPathParser. It makes the code clearer and
look safer. This is performance neutral on Speedometer.

* Source/WTF/wtf/text/StringParsingBuffer.h:
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::isQuoteCharacter):
(WebCore::isValidUnquotedAttributeValueChar):
(WebCore::HTMLFastPathParser::HTMLFastPathParser):
(WebCore::HTMLFastPathParser::parseCompleteInput):
(WebCore::HTMLFastPathParser::scanText):
(WebCore::HTMLFastPathParser::scanEscapedText):
(WebCore::HTMLFastPathParser::scanTagName):
(WebCore::HTMLFastPathParser::scanAttributeName):
(WebCore::HTMLFastPathParser::scanAttributeValue):
(WebCore::HTMLFastPathParser::scanEscapedAttributeValue):
(WebCore::HTMLFastPathParser::scanHTMLCharacterReference):
(WebCore::HTMLFastPathParser::parseChildren):
(WebCore::HTMLFastPathParser::parseAttributes):
(WebCore::HTMLFastPathParser::parseContainerElement):
(WebCore::HTMLFastPathParser::isValidUnquotedAttributeValueChar): Deleted.
(WebCore::HTMLFastPathParser::skipWhitespace): Deleted.
(WebCore::HTMLFastPathParser::peekNext): Deleted.
(WebCore::HTMLFastPathParser::consumeNext): Deleted.

Canonical link: https://commits.webkit.org/260417@main




More information about the webkit-changes mailing list