[webkit-changes] [WebKit/WebKit] aa8d69: Web Inspector: Show rulers when highlighting elements

[Devin Rousso]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: aa8d691bb9b83f178f72fd32ed331ed147e286dd
      https://github.com/WebKit/WebKit/commit/aa8d691bb9b83f178f72fd32ed331ed147e286dd
  Author: Devin Rousso <hi at devinrousso.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/JavaScriptCore/inspector/protocol/DOM.json
    M Source/WebCore/inspector/InspectorOverlay.cpp
    M Source/WebCore/inspector/InspectorOverlay.h
    M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
    M Source/WebCore/inspector/agents/InspectorDOMAgent.h
    M Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js

  Log Message:
  -----------
  Web Inspector: Show rulers when highlighting elements
https://bugs.webkit.org/show_bug.cgi?id=251938

Reviewed by Patrick Angle.

This fully unifies the overlay experience in both element selection mode and when highlighting elements via Web Inspector (e.g. in the Elements Tab).

* Source/JavaScriptCore/inspector/protocol/DOM.json:
* Source/WebCore/inspector/agents/InspectorDOMAgent.h:
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::handleTouchEvent):
(WebCore::InspectorDOMAgent::highlightMousedOverNode):
(WebCore::InspectorDOMAgent::setSearchingForNode):
(WebCore::InspectorDOMAgent::highlightSelector):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
Also allow for a `drawRulers` argument to `DOM.highlightSelector`, `DOM.highlightNode`, and `DOM.highlightNodeList`.
It's necessary to "duplicate" these commands with a `"condition"` due to the fact that rulers are not supported on iOS.

* Source/WebCore/inspector/InspectorOverlay.h:
(WebCore::InspectorOverlay::setShowRulersDuringElementSelection): Deleted.
* Source/WebCore/inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightNodeList):
(WebCore::InspectorOverlay::highlightNode):
(WebCore::InspectorOverlay::shouldShowOverlay const):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::drawElementTitle):
Rename member variables/methods since drawing rulers is now not only about element selection.

* Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:
(WI.DOMManager.buildHighlightConfigs):
(WI.DOMManager.prototype.set inspectModeEnabled):
Set `showRulers` for all commands that could use it.

Canonical link: https://commits.webkit.org/260416@main