[webkit-changes] [WebKit/WebKit] 9ce367: Make WebCore::ScrollPinningBehavior an enum class ...

Simon Fraser noreply at github.com
Thu Feb 16 20:42:07 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9ce367dc009c5bf55efa7cafa0ba720c9694ee31
      https://github.com/WebKit/WebKit/commit/9ce367dc009c5bf55efa7cafa0ba720c9694ee31
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-02-16 (Thu, 16 Feb 2023)

  Changed paths:
    M Source/WebCore/page/FrameView.cpp
    M Source/WebCore/page/FrameView.h
    M Source/WebCore/page/scrolling/ScrollingTree.h
    M Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm
    M Source/WebCore/platform/ScrollTypes.h
    M Source/WebKit/Scripts/webkit/messages.py
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in

  Log Message:
  -----------
  Make WebCore::ScrollPinningBehavior an enum class with generated serialization
https://bugs.webkit.org/show_bug.cgi?id=252438
rdar://105567029

Reviewed by Alex Christensen.

Make WebCore::ScrollPinningBehavior an enum class. Use it in WebPageMessages.in rather
than a uint32_t, and generate the serialization.

* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::minimumScrollPosition const):
(WebCore::FrameView::maximumScrollPosition const):
(WebCore::FrameView::unscaledMinimumScrollPosition const):
(WebCore::FrameView::unscaledMaximumScrollPosition const):
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/scrolling/ScrollingTree.h:
* Source/WebCore/page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::minimumScrollPosition const):
(WebCore::ScrollingTreeFrameScrollingNodeMac::maximumScrollPosition const):
* Source/WebCore/platform/ScrollTypes.h:
* Source/WebKit/Scripts/webkit/messages.py:
(headers_for_type):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm:
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::minimumScrollPosition const):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteIOS::maximumScrollPosition const):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setScrollPinningBehavior):
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/260418@main




More information about the webkit-changes mailing list