[webkit-changes] [WebKit/WebKit] 06e354: [css-properties-values-api] non-inherited custom p...

Antoine Quint noreply at github.com
Fri Feb 3 02:06:34 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06e3540a49d0e77e83fd02402745c1fd6e7e8a8c
      https://github.com/WebKit/WebKit/commit/06e3540a49d0e77e83fd02402745c1fd6e7e8a8c
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance.html
    M Source/WebCore/style/StyleBuilderCustom.h

  Log Message:
  -----------
  [css-properties-values-api] non-inherited custom property fails to inherit from parent when "inherit" is set
https://bugs.webkit.org/show_bug.cgi?id=251590

Reviewed by Antti Koivisto.

We would only look at the map of inherited custom properties when applying the "inherit" value
for a custom property. However, a non-inherited value should also use its parent's value in that
case.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/registered-properties-inheritance.html:
* Source/WebCore/style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInheritCustomProperty):

Canonical link: https://commits.webkit.org/259809@main




More information about the webkit-changes mailing list