[webkit-changes] [WebKit/WebKit] 8940b3: [WGSL] Simplify type checking structure

Tadeu Zagallo noreply at github.com
Fri Feb 3 02:32:31 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8940b332692a90847a1add16b3d44f9da8c1c02e
      https://github.com/WebKit/WebKit/commit/8940b332692a90847a1add16b3d44f9da8c1c02e
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp

  Log Message:
  -----------
  [WGSL] Simplify type checking structure
https://bugs.webkit.org/show_bug.cgi?id=251607
rdar://104966485

Reviewed by Myles C. Maxfield.

As per the feedback in #9463, it doesn't look like the whole constraint solving
is necessary, so I'll remove it and try to keep things as simple.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::check):
(WGSL::TypeChecker::visit):
(WGSL::TypeChecker::infer):
(WGSL::TypeChecker::resolve):
(WGSL::TypeChecker::unify):
(WGSL::UnificationContext::UnificationContext): Deleted.
(WGSL::UnificationContext::~UnificationContext): Deleted.
(WGSL::UnificationContext::unify): Deleted.
(WGSL::UnificationContext::substitute): Deleted.
(WGSL::UnificationContext::solveConstraints): Deleted.
(WGSL::UnificationContext::runSubstitutions): Deleted.
(WGSL::TypeChecker::variable): Deleted.
(WGSL::TypeChecker::substitute): Deleted.

Canonical link: https://commits.webkit.org/259810@main




More information about the webkit-changes mailing list