[webkit-changes] [WebKit/WebKit] b1a581: [web-animations] keyframes should be recomputed wh...
Antoine Quint
noreply at github.com
Fri Feb 3 01:41:30 PST 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b1a5811b30178cebdc1e9ee15161b67f162b1721
https://github.com/WebKit/WebKit/commit/b1a5811b30178cebdc1e9ee15161b67f162b1721
Author: Antoine Quint <graouts at webkit.org>
Date: 2023-02-03 (Fri, 03 Feb 2023)
Changed paths:
M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/KeyframeEffect.h
M Source/WebCore/css/CSSCustomPropertyValue.cpp
M Source/WebCore/css/CSSCustomPropertyValue.h
M Source/WebCore/style/StyleResolver.cpp
M Source/WebCore/style/StyleResolver.h
Log Message:
-----------
[web-animations] keyframes should be recomputed when the "currentcolor" value is used on a custom property
https://bugs.webkit.org/show_bug.cgi?id=251591
Reviewed by Antti Koivisto.
We keep a set of CSS properties set to "currentcolor" in a KeyframeEffect but until now only considered
"standard" CSS properties. We now also consider custom properties by changing the set's type from
HashSet<CSSPropertyID> to HashSet<AnimatableProperty>.
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/at-property-animation.html:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::updateBlendingKeyframes):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/css/CSSCustomPropertyValue.cpp:
(WebCore::CSSCustomPropertyValue::isCurrentColor const):
* Source/WebCore/css/CSSCustomPropertyValue.h:
* Source/WebCore/style/StyleResolver.cpp:
(WebCore::Style::Resolver::keyframeStylesForAnimation):
* Source/WebCore/style/StyleResolver.h:
Canonical link: https://commits.webkit.org/259808@main
More information about the webkit-changes
mailing list