[webkit-changes] [WebKit/WebKit] 65d13d: [IFC][Geometry] Ruby annotation box geometry shoul...

Alan Baradlay noreply at github.com
Fri Dec 29 05:41:00 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 65d13d0e7fdcc666c89609fab30770f457d757bc
      https://github.com/WebKit/WebKit/commit/65d13d0e7fdcc666c89609fab30770f457d757bc
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-12-29 (Fri, 29 Dec 2023)

  Changed paths:
    M LayoutTests/fast/ruby/ruby-in-vertical-writing-mode-with-long-annotation-expected.html
    M LayoutTests/platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [IFC][Geometry] Ruby annotation box geometry should all be visual
https://bugs.webkit.org/show_bug.cgi?id=266923

Reviewed by Antti Koivisto.

This is in preparation for fixing webkit.org/b/266814 where final box geometries should be all visual.

(Rebaseline for progressions now that we don't process the same annotation on multiple lines with spanning bases)

* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.h:
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::processRubyBase):
(WebCore::Layout::InlineDisplayContentBuilder::processRubyContent):
* Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationBefore):
(WebCore::Layout::RubyFormattingContext::overhangForAnnotationAfter):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::updateRenderTreePositions):

Canonical link: https://commits.webkit.org/272529@main




More information about the webkit-changes mailing list