[webkit-changes] [WebKit/WebKit] 413412: [WebGPU] unpack4x8unorm does not appear to be impl...

Tadeu Zagallo noreply at github.com
Fri Dec 29 04:10:45 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 41341242c718622e4e3b1970cb19197f2af39bfc
      https://github.com/WebKit/WebKit/commit/41341242c718622e4e3b1970cb19197f2af39bfc
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-12-29 (Fri, 29 Dec 2023)

  Changed paths:
    M Source/WebGPU/WGSL/ConstantFunctions.h
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/TypeDeclarations.rb
    M Source/WebGPU/WGSL/tests/valid/overload.wgsl
    A Source/WebGPU/WGSL/tests/valid/pack-unpack.wgsl

  Log Message:
  -----------
  [WebGPU] unpack4x8unorm does not appear to be implemented
https://bugs.webkit.org/show_bug.cgi?id=266871
rdar://120107356

Reviewed by Mike Wyrzykowski.

Implement data packing[1] and unpacking[2] built-in functions.

[1]. https://www.w3.org/TR/WGSL/#pack-builtin-functions
[2]. https://www.w3.org/TR/WGSL/#unpack-builtin-functions

* Source/WebGPU/WGSL/ConstantFunctions.h:
(WGSL::CONSTANT_FUNCTION):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::emitPack2x16Float):
(WGSL::Metal::emitUnpack2x16Float):
(WGSL::Metal::emitPack4xI8):
(WGSL::Metal::emitPack4xI8Clamp):
(WGSL::Metal::emitUnpack4xI8):
(WGSL::Metal::emitPack4xU8):
(WGSL::Metal::emitPack4xU8Clamp):
(WGSL::Metal::emitUnpack4xU8):
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeDeclarations.rb:
* Source/WebGPU/WGSL/tests/valid/overload.wgsl:
* Source/WebGPU/WGSL/tests/valid/pack-unpack.wgsl: Added.

Canonical link: https://commits.webkit.org/272528@main




More information about the webkit-changes mailing list