[webkit-changes] [WebKit/WebKit] 7883e9: getElementsByName() should only return HTML elements

[Anne van Kesteren]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7883e9ca30c85590b7ac6f16a8b2bbec71fa9d51
      https://github.com/WebKit/WebKit/commit/7883e9ca30c85590b7ac6f16a8b2bbec71fa9d51
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2023-12-29 (Fri, 29 Dec 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt
    M Source/WebCore/dom/ContainerNode.cpp
    M Source/WebCore/dom/ContainerNode.h
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/dom/Document.h
    M Source/WebCore/dom/NameNodeList.cpp
    M Source/WebKitLegacy/mac/DOM/DOMDocument.mm
    M Source/WebKitLegacy/mac/DOM/DOMElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLButtonElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLCollection.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm
    M Source/WebKitLegacy/mac/DOM/DOMHTMLSelectElement.mm

  Log Message:
  -----------
  getElementsByName() should only return HTML elements
https://bugs.webkit.org/show_bug.cgi?id=266894

Reviewed by Simon Fraser.

Move getElementsByName() from ContainerNode to Document, make
NameNodeList only match HTML elements, and remove superfluous
NameNodeList.h includes.

This aligns us with the HTML Standard and Firefox, and generally cleans
up the code.

* LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt:
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::getElementsByName): Deleted.
* Source/WebCore/dom/ContainerNode.h:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::getElementsByName):
* Source/WebCore/dom/Document.h:
* Source/WebCore/dom/NameNodeList.cpp:
(WebCore::NameNodeList::elementMatches const):
* Source/WebKitLegacy/mac/DOM/DOMDocument.mm:
* Source/WebKitLegacy/mac/DOM/DOMElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLButtonElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLCollection.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLInputElement.mm:
* Source/WebKitLegacy/mac/DOM/DOMHTMLSelectElement.mm:

Canonical link: https://commits.webkit.org/272530@main