[webkit-changes] [WebKit/WebKit] 77cb34: [UIAsyncTextInput] Release assertion when dismissi...

Wenson Hsieh noreply at github.com
Sun Dec 3 12:24:35 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 77cb34332913a8cca17e59e72822d6230dc68d1e
      https://github.com/WebKit/WebKit/commit/77cb34332913a8cca17e59e72822d6230dc68d1e
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-12-03 (Sun, 03 Dec 2023)

  Changed paths:
    M Source/WebKit/Platform/spi/ios/UIKitSPI.h
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  [UIAsyncTextInput] Release assertion when dismissing the keyboard or changing focused element
https://bugs.webkit.org/show_bug.cgi?id=265736

Reviewed by Tim Horton.

Simply delete this codepath, instead of release asserting. The only call site of this method is from
`UIDictationController` in UIKit, which is gated on a `-respondsToSelector:` check.

Since this isn't needed for binary compatibility with any other internal apps, and the resulting
behavior in `-[UIDictationController logCorrectionStatisticsForDelegate:reason:]` is unchanged, we
should just delete this code altogether.

* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView metadataDictionariesForDictationResults]): Deleted.

Canonical link: https://commits.webkit.org/271442@main




More information about the webkit-changes mailing list