[webkit-changes] [WebKit/WebKit] 69b2ba: Increase styleType bits to 5 on `RenderStyle::NonI...

Tim Nguyen noreply at github.com
Sun Dec 3 11:56:43 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69b2bad2e262920da7314d9c9d8468672b8f0c7b
      https://github.com/WebKit/WebKit/commit/69b2bad2e262920da7314d9c9d8468672b8f0c7b
  Author: Tim Nguyen <ntim at apple.com>
  Date:   2023-12-03 (Sun, 03 Dec 2023)

  Changed paths:
    M Source/WebCore/rendering/style/RenderStyle.cpp
    M Source/WebCore/rendering/style/RenderStyle.h

  Log Message:
  -----------
  Increase styleType bits to 5 on `RenderStyle::NonInheritedFlags`
https://bugs.webkit.org/show_bug.cgi?id=265750
rdar://119091107

Reviewed by Aditya Keerthi.

271271 at main increased the size of the PseudoId enum, but did not increase the styleType bits accordingly, increase them otherwise `PseudoId::ViewTransitionNew` will be considered as `PseudoId::None`.

This will be noticeable when the rendering of the view transitions will be implemented.

Add a `static_assert` to prevent this from happening again.

* Source/WebCore/rendering/style/RenderStyle.cpp:
* Source/WebCore/rendering/style/RenderStyle.h:

Canonical link: https://commits.webkit.org/271441@main




More information about the webkit-changes mailing list