[webkit-changes] [WebKit/WebKit] 3d19f6: Do a full repaint when the old and new clippedOver...

Simon Fraser noreply at github.com
Sun Dec 3 12:30:42 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d19f69ee7b4937ee44a021a267297c47ea69185
      https://github.com/WebKit/WebKit/commit/3d19f69ee7b4937ee44a021a267297c47ea69185
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2023-12-03 (Sun, 03 Dec 2023)

  Changed paths:
    M LayoutTests/platform/ios/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt
    M LayoutTests/platform/ios/svg/repaint/text-repainting-after-modifying-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/foreign-object-repainting-after-modifying-container-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/foreign-object-repainting-after-modifying-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/image-repainting-after-modifying-container-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/image-repainting-after-modifying-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/shape-repainting-after-modifying-container-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/shape-repainting-after-modifying-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt
    M LayoutTests/svg/repaint/text-repainting-after-modifying-transform-repaint-rects-expected.txt
    M Source/WebCore/rendering/RenderElement.cpp

  Log Message:
  -----------
  Do a full repaint when the old and new clippedOverflowRects don't overlap
https://bugs.webkit.org/show_bug.cgi?id=265754
rdar://119098796

Reviewed by Alan Baradlay.

In the non-full repaint code path, RenderElement::repaintAfterLayoutIfNeeded() does repaints based on the deltas
of each edge of the rects. This makes no sense if the rects don't overlap, so in that case just do a full repaint.

* LayoutTests/platform/ios/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt:
* LayoutTests/platform/ios/svg/repaint/text-repainting-after-modifying-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/foreign-object-repainting-after-modifying-container-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/foreign-object-repainting-after-modifying-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/image-repainting-after-modifying-container-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/image-repainting-after-modifying-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/shape-repainting-after-modifying-container-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/shape-repainting-after-modifying-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/text-repainting-after-modifying-container-transform-repaint-rects-expected.txt:
* LayoutTests/svg/repaint/text-repainting-after-modifying-transform-repaint-rects-expected.txt:
* Source/WebCore/rendering/RenderElement.cpp:
(WebCore::RenderElement::repaintAfterLayoutIfNeeded):

Canonical link: https://commits.webkit.org/271443@main




More information about the webkit-changes mailing list