[webkit-changes] [WebKit/WebKit] e21f22: [import-w3c-tests] Honor skip expectation with --s...

Sam Sneddon noreply at github.com
Mon Aug 21 08:26:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e21f2280dbbbfe4fcc4801dcf4ad83d09f0621d8
      https://github.com/WebKit/WebKit/commit/e21f2280dbbbfe4fcc4801dcf4ad83d09f0621d8
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_downloader.py
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [import-w3c-tests] Honor skip expectation with --src-dir
https://bugs.webkit.org/show_bug.cgi?id=257198
rdar://problem/110004053

Reviewed by Jonathan Bedard.

Previously, we only applied the skip logic in test_downloader, and hence
it only had any effect when downloading tests, and not when importing
from a given --src-dir.

* Tools/Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader._add_test_suite_paths):
(TestDownloader.copy_tests.should_copy_dir):
(TestDownloader.copy_tests.should_copy_file):
* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter.should_skip_path):
(TestImporter.find_importable_tests):
(TestImporter.should_skip_file): Deleted.
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:

Canonical link: https://commits.webkit.org/267088@main




More information about the webkit-changes mailing list