[webkit-changes] [WebKit/WebKit] c2f1b3: [import-w3c-tests] Fix reftest path resolution wit...

[Sam Sneddon]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c2f1b3775319389cbd947580b2af62d88a19de9a
      https://github.com/WebKit/WebKit/commit/c2f1b3775319389cbd947580b2af62d88a19de9a
  Author: Sam Sneddon <gsnedders at apple.com>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M Tools/Scripts/webkitpy/w3c/test_importer.py
    M Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

  Log Message:
  -----------
  [import-w3c-tests] Fix reftest path resolution with -s
https://bugs.webkit.org/show_bug.cgi?id=257674
rdar://problem/110201843

Reviewed by Jonathan Bedard.

Previously, bf94a2f96abf implemented this with differing behaviour
depending on whether `-s` was provided; if `-s` wasn't provided then
absolute reftest links were resolved relative to the WPT repo root, but
if `-s` was provided then they were resolved relative to the parent of
the WPT repo root.

This difference obviously breaks workflows where `-s` is being provided
to avoid having to re-clone WPT, and it's unclear what the motivation
for the difference in behaviour was.

We now behave the same in both cases, thus passing `-s` to avoid
re-cloning WPT still leads to the correct behaviour.

* Tools/Scripts/webkitpy/w3c/test_importer.py:
(TestImporter._source_root_directory_for_path):
* Tools/Scripts/webkitpy/w3c/test_importer_unittest.py:

Canonical link: https://commits.webkit.org/267087@main