[webkit-changes] [WebKit/WebKit] 06b30c: Set <details> ToggleEvent oldState correctly for c...

sideshowbarker noreply at github.com
Mon Aug 21 09:14:13 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 06b30c68edf91408b614dbd577f4c211b4b3f000
      https://github.com/WebKit/WebKit/commit/06b30c68edf91408b614dbd577f4c211b4b3f000
  Author: Michael[tm] Smith <mike at w3.org>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent.html
    M Source/WebCore/html/HTMLDetailsElement.cpp

  Log Message:
  -----------
  Set <details> ToggleEvent oldState correctly for coalesced tasks
https://bugs.webkit.org/show_bug.cgi?id=260463

Reviewed by Tim Nguyen.

Set the ToggleEvent oldState value correctly in the case where a
<details> element is open and closed multiple times (toggled back and
forth) — which https://commits.webkit.org/267076@main didn’t get right.

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent.html:
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::queueDetailsToggleEventTask):

Canonical link: https://commits.webkit.org/267089@main




More information about the webkit-changes mailing list