[webkit-changes] [WebKit/WebKit] d15d7a: AX: aria-labelledby-on-password-input fails in ITM

Joshua Hoffman noreply at github.com
Mon Aug 21 07:20:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d15d7af722dcc95a4245508c7f41cb84edaf3d11
      https://github.com/WebKit/WebKit/commit/d15d7af722dcc95a4245508c7f41cb84edaf3d11
  Author: hoffmanjoshua <jhoffman23 at apple.com>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M LayoutTests/accessibility-isolated-tree/TestExpectations
    M LayoutTests/accessibility/aria-labelledby-on-password-input.html
    A LayoutTests/accessibility/aria-labelledby-text-expected.txt
    A LayoutTests/accessibility/aria-labelledby-text.html
    M LayoutTests/platform/glib/TestExpectations
    M Source/WebCore/accessibility/AXObjectCache.cpp

  Log Message:
  -----------
  AX: aria-labelledby-on-password-input fails in ITM
https://bugs.webkit.org/show_bug.cgi?id=260190
rdar://113885331

Reviewed by Andres Gonzalez.

Previously in ITM, if an element had `aria-labelledby`, changes to the labeling element would not update the node of the labeled element. This patch adds logic inside the `handleChildrenChanged` method to notify the labeled elements when the value of a labeling element changes.

* LayoutTests/accessibility-isolated-tree/TestExpectations
* LayoutTests/accessibility/aria-labelledby-on-password-input.html:

Update layout tests to wait for async value change.

* LayoutTests/platform/glib/TestExpectations

Skip on GTK/WPE.

* Source/WebCore/accessibility/AXObjectCache.cpp
(WebCore::AXObjectCache::handleChildrenChanged):

Checks if self or ancestors label other elements, and updats the labeled (related) elements.

* LayoutTests/accessibility/aria-labelledby-text-expected.txt: Added.
* LayoutTests/accessibility/aria-labelledby-text.html: Added.

New tests to check that text changes, attribute changes, for labelledby elements update properly.

Canonical link: https://commits.webkit.org/267086@main




More information about the webkit-changes mailing list