[webkit-changes] [WebKit/WebKit] cfbd8f: Web Inspector: Move details sidebar to bottom when...

mirnovov noreply at github.com
Thu Aug 10 14:59:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfbd8f5ff5d3376688299cfe672e0bba44725372
      https://github.com/WebKit/WebKit/commit/cfbd8f5ff5d3376688299cfe672e0bba44725372
  Author: novov <anon185441 at gmail.com>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
    M Source/WebInspectorUI/UserInterface/Base/Main.js
    M Source/WebInspectorUI/UserInterface/Base/Setting.js
    A Source/WebInspectorUI/UserInterface/Images/ToggleBottomSidebar.svg
    M Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js
    M Source/WebInspectorUI/UserInterface/Views/Main.css
    M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
    M Source/WebInspectorUI/UserInterface/Views/Sidebar.css
    M Source/WebInspectorUI/UserInterface/Views/Sidebar.js
    M Source/WebInspectorUI/UserInterface/Views/SingleSidebar.css
    M Source/WebInspectorUI/UserInterface/Views/SingleSidebar.js
    M Source/WebInspectorUI/UserInterface/Views/TabBrowser.js
    M Source/WebInspectorUI/UserInterface/Views/TabContentView.js

  Log Message:
  -----------
  Web Inspector: Move details sidebar to bottom when narrow

https://bugs.webkit.org/show_bug.cgi?id=259391

Reviewed by Devin Rousso.

When the Inspector is very narrow (around 500px or less wide) it is difficult to use.
This patch adds WI.LayoutMode, which specifies a narrow layout which is instated below a certain width. The layout can be queried by subsidiary views so they can be displayed differently.
Currently, this changes the details sidebar so it appears at the bottom when the Inspector is below a certain width, similar to Blink and Gecko's developer tools.

Combined changes:
* Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:
* Source/WebInspectorUI/UserInterface/Base/Main.js:
* Source/WebInspectorUI/UserInterface/Base/Setting.js:
* Source/WebInspectorUI/UserInterface/Images/ToggleBottomSidebar.svg: Added.
* Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js:
(WI.ContentBrowserTabContentView.prototype._detailsSidebarPositionDidChange):
* Source/WebInspectorUI/UserInterface/Views/Main.css:
(#navigation-sidebar):
(#content):
(body[dir="rtl"] #content):
(body.narrow #content):
(body[dir="rtl"].narrow #content):
(#tab-browser):
(#details-sidebar):
* Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createGeneralSettingsView):
* Source/WebInspectorUI/UserInterface/Views/Sidebar.css:
(body.narrow .sidebar.trailing):
* Source/WebInspectorUI/UserInterface/Views/Sidebar.js:
(WI.Sidebar):
(WI.Sidebar.prototype.get height):
(WI.Sidebar.prototype.set height):
(WI.Sidebar.prototype.sizeDidChange):
(WI.Sidebar.prototype.resizerDragStarted):
(WI.Sidebar.prototype.resizerDragging):
(WI.Sidebar.prototype.resizerDragEnded):
(WI.Sidebar.prototype._recalculateHeight):
* Source/WebInspectorUI/UserInterface/Views/SingleSidebar.css:
(body:not(.narrow) .single-sidebar.trailing):
(body.narrow .sidebar.trailing .single-sidebar):
(body.narrow .sidebar.trailing .single-sidebar .resizer):
(.single-sidebar.trailing): Deleted.
* Source/WebInspectorUI/UserInterface/Views/SingleSidebar.js:
(WI.SingleSidebar):
(WI.SingleSidebar.prototype.get widthResizer):
(WI.SingleSidebar.prototype.resizerDragStarted):
(WI.SingleSidebar.prototype.resizerDragging):
(WI.SingleSidebar.prototype.resizerDragEnded):
* Source/WebInspectorUI/UserInterface/Views/TabBrowser.js:
(WI.TabBrowser):
(WI.TabBrowser.prototype._handleSidebarSizeDidChange):
(WI.TabBrowser.prototype._handleSidebarPositionDidChange):
(WI.TabBrowser.prototype._showDetailsSidebarPanelsForTabContentView):
(WI.TabBrowser.prototype._handleSidebarWidthDidChange): Deleted.
* Source/WebInspectorUI/UserInterface/Views/TabContentView.js:
(WI.TabContentView.prototype.get detailsSidebarHeightSetting):
(WI.TabContentView):

Canonical link: https://commits.webkit.org/266784@main




More information about the webkit-changes mailing list