[webkit-changes] [WebKit/WebKit] 6d291b: Web Inspector: No search results

Frances Cornwall noreply at github.com
Thu Aug 10 14:31:16 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6d291b6825cc243898c27d8d97d35a20a2ca0b64
      https://github.com/WebKit/WebKit/commit/6d291b6825cc243898c27d8d97d35a20a2ca0b64
  Author: Frances Cornwall <frances_c at cox.net>
  Date:   2023-08-10 (Thu, 10 Aug 2023)

  Changed paths:
    M Source/WebInspectorUI/UserInterface/Views/FindBanner.js

  Log Message:
  -----------
  Web Inspector: No search results
https://bugs.webkit.org/show_bug.cgi?id=259843

Reviewed by Devin Rousso.

Web Inspector search is not working due to _inputFieldSearch(event) not
being triggered.

Replace incremental with throttle and replace "search" with "input".

Import Throttler class to add _inputFieldInputThrottler function to handle throttler for "input" using fire function.
Incorporate 250 ms delay.

In _inputFieldKeyDown use findBannerRevealPreviousResult and findBannerRevealNextResult for shift and enter key presses
replacing _searchBackwards and _searchForwards.

Delete _inputFieldKeyUp.

Delete _searchBackwards and _searchForwards in _inputFieldInput(event).

* Source/WebInspectorUI/UserInterface/Views/FindBanner.js:
(WI.FindBanner.prototype._inputFieldKeyDown):
(WI.FindBanner.prototype._inputFieldInput):
(WI.FindBanner.prototype._inputFieldKeyUp): Deleted.
(WI.FindBanner.prototype._inputFieldSearch): Deleted.

Canonical link: https://commits.webkit.org/266783@main




More information about the webkit-changes mailing list