[webkit-changes] [WebKit/WebKit] 81f8f7: Un-necessary text track reconfigurations causes fu...

Jean-Yves Avenard noreply at github.com
Fri Apr 28 16:55:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 81f8f7f4b68421ec53e649a7649b12744e1981fc
      https://github.com/WebKit/WebKit/commit/81f8f7f4b68421ec53e649a7649b12744e1981fc
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Source/WebCore/html/HTMLMediaElement.cpp
    M Source/WebCore/html/HTMLMediaElement.h

  Log Message:
  -----------
  Un-necessary text track reconfigurations causes full re-layout
https://bugs.webkit.org/show_bug.cgi?id=256090
rdar://108381732

Reviewed by Jer Noble.

We only need to reconfigure the text tracks if the language has changed
since the last time it was initialized.

* Source/WebCore/html/HTMLMediaElement.cpp: cache the current languageOfPrimaryAudioTrack
and only execute markCaptionAndSubtitleTracksAsUnconfigured if original has changed.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
* Source/WebCore/html/HTMLMediaElement.h:

Canonical link: https://commits.webkit.org/263521@main




More information about the webkit-changes mailing list