[webkit-changes] [WebKit/WebKit] 4f0df9: REGRESSION (262297 at main): Cursor styles don't work...

Wenson Hsieh noreply at github.com
Fri Apr 28 17:16:29 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4f0df9c94db252f1c5fe1be436f87d2bb611cec5
      https://github.com/WebKit/WebKit/commit/4f0df9c94db252f1c5fe1be436f87d2bb611cec5
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

  Log Message:
  -----------
  REGRESSION (262297 at main): Cursor styles don't work in Catalyst apps that don't support indirect touches
https://bugs.webkit.org/show_bug.cgi?id=256110
rdar://108072867

Reviewed by Tim Horton.

262297 at main removed `@(UITouchTypeDirect)` from the set of allowed touch types; however, this is
still necessary in order for tracking (and cursor styles) to work in Catalyst apps that don't have
the `UIApplicationSupportsIndirectInputEvents` application plist key set, since the mouse gesture
(which also handles hover in Catalyst) still relies on sending direct touches.

Instead, we can keep the behavior following 262297 at main intact while also keeping this Catalyst case
working by:

1.  Putting `UITouchTypeDirect` back in the allowed touch types list, and…
2.  Using the `-_isPointerTouch` SPI to reject touches that aren't actually sent via trackpad, via
    the gesture recognizer delegate hook.

* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):
(-[WKContentView _configureMouseGestureRecognizer]):

Canonical link: https://commits.webkit.org/263522@main




More information about the webkit-changes mailing list