[webkit-changes] [WebKit/WebKit] d069b9: Enable strict decoding of NSURLProtectionSpace beh...

Alex Christensen noreply at github.com
Fri Apr 28 16:09:17 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d069b94b2d7ba4e09f1e2dab850b4c3f52bd6a82
      https://github.com/WebKit/WebKit/commit/d069b94b2d7ba4e09f1e2dab850b4c3f52bd6a82
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2023-04-28 (Fri, 28 Apr 2023)

  Changed paths:
    M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm

  Log Message:
  -----------
  Enable strict decoding of NSURLProtectionSpace behind runtime flag
https://bugs.webkit.org/show_bug.cgi?id=256107
rdar://108675120

Reviewed by David Kilzer.

Even before rdar://107730786 is resolved, we can strictly decode NSURLProtectionSpace
by simply transforming the NSMutableDictionary serialized members to NSDictionary members
like we do with NSURLCredential.  Enable strict decoding when strictSecureDecodingForAllObjCEnabled
returns true.

I also separate the remaining non-strict-decoded ObjC classes so their strict decoding can be
enabled with straightforward changes, and annotated each one with the blocking radar.
To make the logic less cluttered, I move the lists of MessageNames to lambdas.  These changes
don't change behavior now.

* Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm:
(IPC::encodeSecureCodingInternal):
(IPC::shouldEnableStrictMode):

Canonical link: https://commits.webkit.org/263520@main




More information about the webkit-changes mailing list